Observable emitted from RxBleConnection.setupNotification()/RxBleConnection.setupIndication() does not complete

[dariuszseweryn]

Summary

Currently when the user will unsubscribe from .setupNotification()/.setupIndication() the notification/indication is teardown but the (possibly) emitted Observable<byte[]> does not complete.
Similarly when the RxBleConnection terminates the emitted Observable<byte[]> does not throw an error.

Library version

1.3.1

Steps to reproduce actual result

1. Connect to a device

2. Setup notification (or indication)

3. Wait for it being setup

4. Get emitted Observable<byte[]>

5. Un-subscribe from the .setup*()

6. Observe that emitted Observable<byte[]> has not completed

Minimum code snippet reproducing the issue

rxBleDevice.establishConnection(false)
                .flatMap(connection -> connection.setupNotification(characteristicUuid)
                        .takeUntil(Observable.timer(15, TimeUnit.SECONDS))
                        .flatMap(observable -> observable)
                        .doOnCompleted(() -> Log.d("SHOULD", "COMPLETE"))
                )
                .subscribe();

Actual result

SHOULD COMPLETE is not logged after 15 seconds from the notification setup.

Expected result

SHOULD COMPLETE should be logged after 15 seconds from the notification setup.

[RobLewis]

Haven't thought this through, but will this fix require any changes to ConnectionSharingAdapter?

[dariuszseweryn]

@RobLewis No.