Fix notify/indicate observable termination #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubscribe and propagate disconnect.
dariuszseweryn
changed the title
uKL
approved these changes
Jun 26, 2017
| @@ -349,6 +353,46 @@ class NotificationAndIndicationManagerTest extends RoboSpecification { | |||
| ].combinations() | |||
| } | |||
|
|
|||
| @Unroll | |||
| def "should complete the emitted Observable<byte> when un-subscribed"() { | |||
dariuszseweryn
deleted the
fix/issue_231_notification_observable_does_not_terminate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #231
Until now the
Observable<byte[]>emitted fromRxBleConnection.setupNotification()/RxBleConnection.setupIndication()did not complete when theRxBleConnection.setupNotification()/RxBleConnection.setupIndication()was unsubscribed and notification/indication was teardown. Additionally theObservable<byte[]>did not propagate errors when theRxBleConnectionhas disconnected. This behaviour is fixed with this Pull Request.