Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Android Groovy Plugin workaround with a new plugin version #309

Closed
uKL opened this issue Nov 6, 2017 · 2 comments
Closed

Replace Android Groovy Plugin workaround with a new plugin version #309

uKL opened this issue Nov 6, 2017 · 2 comments
Assignees
@uKL
Labels
bug Bug that is caused by the library enhancement

Comments

@uKL
Copy link
Collaborator

uKL commented Nov 6, 2017

With Gradle 3.0.0 there's an issue with compatibility with Groovy (groovy/groovy-android-gradle-plugin#156).

Currently, @mapyo introduced a workaround in rxandroidble/build.gradle. Once the new version of Groovy plugin is released it would be good to bump it in our code and get rid of the workaround.
@uKL uKL added bug Bug that is caused by the library enhancement labels Nov 6, 2017
@uKL uKL self-assigned this Nov 6, 2017
uKL added a commit that referenced this issue Nov 21, 2017
@uKL
[#309] Migrated to Groovy plugin 2.0.0 which is fixing issues with Gr…
0819183 
…adle 3.0.0 and the newest Android plugin.
uKL added a commit that referenced this issue Nov 21, 2017
@uKL
[#309] Removed a workaround that created apt directories in tests. Gr…
47de662 
…oovy plugin will handle it itself when skipJavaC is applied.
uKL added a commit that referenced this issue Nov 22, 2017
@uKL
Gradle plugin 2.0.0 & misspell in exception (#325)
841fd6e 
* Fixed a misspelling in an exception print out.

* [#309] Migrated to Groovy plugin 2.0.0 which is fixing issues with Gradle 3.0.0 and the newest Android plugin.

* [#309] Removed a workaround that created apt directories in tests. Groovy plugin will handle it itself when skipJavaC is applied.
@dariuszseweryn
Copy link
Owner

I think this may be closed now with the plugin in version 2.0.0.

@uKL
Copy link
Collaborator Author

uKL commented Nov 23, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uKL uKL

Labels
bug Bug that is caused by the library enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dariuszseweryn @uKL