Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes UUIDUtil constructor public to solve Kotlin problem #184

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Makes UUIDUtil constructor public to solve Kotlin problem #184

merged 1 commit into from
Apr 28, 2017

Conversation

marciogranzotto
Copy link

Android Studio, while using Kotlin, was complaining that couldn't initialize the UUIDUtil class because the constructor wasn't public.

@dariuszseweryn
Copy link
Owner

Hello
Why would you like to use UUIDUtil? It is in internal package and is not intended for public accesibility

@marciogranzotto
Copy link
Author

marciogranzotto commented Apr 27, 2017

I would like to use it's extractUUIDs method to get the UUIDs of a scanResult object. There's several StackOverflow answers that recommend using this method

@lukevr
Copy link

lukevr commented Apr 28, 2017

Hi,
I am playing with RxAndroidBle 1.2.1 and have got an issue with scanBleDevices(UUIDArray), seems that if I have UUIDArray with several different UUID, scanning is not working. Well, at least no results for subscriber in this case.
If I add just one UUID, or same UUID several times to the UUIDArray then rxBleScanResult is present, and everything is ok.

Found similar issue on stackoverflow:
http://stackoverflow.com/questions/40447272/rxandroidble-the-method-scanbledevicesuuid-filters-is-not-support-for-two-t

Custom filter and UUIDUtil are suggested to be used. And, yes UUIDUtil is not public in 1.2.1.

What is the best way to solve the issue with scanning a set of different UUID?

Thanks in advance,
Victor.

@dariuszseweryn
Copy link
Owner

@marciogranzotto I will think today how to properly address the issue. The UUIDUtil is in internal package and nothing from there should be used outside of the library. I will probably add some UUIDHelper and add it to the helper package.
@lukevr The answer is provided in the SO post you have referenced. A custom filter.

@dariuszseweryn dariuszseweryn merged commit c607389 into dariuszseweryn:master Apr 28, 2017
dariuszseweryn added a commit that referenced this pull request Apr 28, 2017
…sedServiceUUIDExtractor helper instead.

#184

UUIDUtil needs to be public now because it was mentioned several times on Stackoverflow answers.
@dariuszseweryn
Copy link
Owner

I have just released 1.2.2 with this change and AdvertisedServiceUUIDExtractor helper which you should use instead of an internal UUIDUtil.

It should be visible shortly.

Best Regards

@uKL
Copy link
Collaborator

uKL commented Mar 20, 2018

Dear Contributor,

similar to many open source projects we kindly request to sign our CLA if you'd like to contribute to our project. This license is for your protection as a Contributor as well as the protection of Polidea; it does not change your rights to use your own Contributions for any other purpose.

You can find a link here: https://cla-assistant.io/Polidea/RxAndroidBle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants