Fixed scan filtering by name for API <21. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was observed for API <21 the name is not always available in the `ScanRecord` but it is available in the `BluetoothDevice`. On API >=21 this issue is not visible.
uKL
requested changes
Jul 5, 2017
| return false; | ||
| if (mDeviceName != null) { | ||
| final boolean advertisedDeviceNameMatches = mDeviceName.equals(scanRecord.getDeviceName()); | ||
| final boolean bluetoothDeviceNameMatches = mDeviceName.equals(device.getName()); |
There was a problem hiding this comment.
Small but pricy optimization. You can inline check from line 282 (and extract to a method) to avoid code execution when it's not required.
In this example the second check will be executed regardless the first one (even if deviceName matches).
uKL
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was observed for API <21 the name is not always available in the
ScanRecordbut it is available in theBluetoothDevice. On API >=21 this issue is not visible.