-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of a custom logger (Timber) instead of Logcat #248
Allow usage of a custom logger (Timber) instead of Logcat #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great idea and addition. Just two thoughts:
- since it is enhancement of the API this should be merged to the
development
branch which will be merged tomaster
on release of1.4.0
- It would be good to an add appropriate note to
README.md
andCHANGELOG.md
Otherwise it is a great feature and I am looking forward to merge it. 👍
} | ||
|
||
/** | ||
* set a custom logger, {@code null} to use default logcat logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start the line with a capital letter
/** | ||
* set a custom logger, {@code null} to use default logcat logging | ||
* | ||
* Combine it with Timber:<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like: Example of how to integrate with Timber:
?
Log messages can now be forwarded to crash reporting tools (crashlytics)
Rebased, added to feature to |
Dear Contributor, similar to many open source projects we kindly request to sign our CLA if you'd like to contribute to our project. This license is for your protection as a Contributor as well as the protection of Polidea; it does not change your rights to use your own Contributions for any other purpose. You can find a link here: https://cla-assistant.io/Polidea/RxAndroidBle |
#Log messages can now be forwarded to crash reporting tools (crashlytics)
Usage