Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of a custom logger (Timber) instead of Logcat #248

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Allow usage of a custom logger (Timber) instead of Logcat #248

merged 3 commits into from
Jul 17, 2017

Conversation

passsy
Copy link
Contributor

@passsy passsy commented Jul 12, 2017

#Log messages can now be forwarded to crash reporting tools (crashlytics)

Usage

RxBleLog.setLogger(new RxBleLog.Logger() {
    @Override
    public void log(final int level, final String tag, final String msg) {
        Timber.tag(tag).log(level, msg);
    }
});

@dariuszseweryn dariuszseweryn self-requested a review July 12, 2017 12:14
@dariuszseweryn dariuszseweryn added this to the 1.4.0 milestone Jul 12, 2017
Copy link
Owner

@dariuszseweryn dariuszseweryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great idea and addition. Just two thoughts:

  • since it is enhancement of the API this should be merged to the development branch which will be merged to master on release of 1.4.0
  • It would be good to an add appropriate note to README.md and CHANGELOG.md
    Otherwise it is a great feature and I am looking forward to merge it. 👍

}

/**
* set a custom logger, {@code null} to use default logcat logging
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the line with a capital letter

/**
* set a custom logger, {@code null} to use default logcat logging
*
* Combine it with Timber:<br>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like: Example of how to integrate with Timber:?

@passsy passsy changed the base branch from master to develop July 14, 2017 15:35
@passsy
Copy link
Contributor Author

passsy commented Jul 14, 2017

Rebased, added to feature to CHANGELOG and README.md

@dariuszseweryn dariuszseweryn merged commit e806713 into dariuszseweryn:develop Jul 17, 2017
@passsy passsy deleted the feature/custom_logger branch July 17, 2017 12:06
@uKL
Copy link
Collaborator

uKL commented Mar 20, 2018

Dear Contributor,

similar to many open source projects we kindly request to sign our CLA if you'd like to contribute to our project. This license is for your protection as a Contributor as well as the protection of Polidea; it does not change your rights to use your own Contributions for any other purpose.

You can find a link here: https://cla-assistant.io/Polidea/RxAndroidBle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants