-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaded Dagger dependency, fixes #342 #343
Conversation
bfbf257
to
e117cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 All good.
I would like to see the difference in the library size and method count after this change.
I am thinking if this should land in |
Having used a transitive dependency is an antipattern anyways. The same was with the rxandroid when we removed it. In case of the dagger, there is a small chance that someone is using it this way due to the compiler dependency. It has to be added directly. |
Antipattern or not-still it can be something that breaks builds. |
Just to be safe we can go forward to 1.5.0 (we have changes related to operation timeout) |
I am just thinking whether we should temporarily revert operation timeout changes, release |
I'm gonna need them soon anyway so we can go with 1.5.0. |
Before:
After:
Additionally, there is a JAR with 41kB with the shaded Dagger containing 187 methods.