Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaded Dagger dependency, fixes #342 #343

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Shaded Dagger dependency, fixes #342 #343

merged 1 commit into from
Jan 4, 2018

Conversation

uKL
Copy link
Collaborator

@uKL uKL commented Dec 21, 2017

Before:

Task :rxandroidble:countReleaseDexMethods 
Total methods in rxandroidble-release.aar: 2234 
Total fields in rxandroidble-release.aar:  1072 
Total classes in rxandroidble-release.aar:  513 
AAR size 374kB

After:

Task :rxandroidble:countReleaseDexMethods 
Total methods in rxandroidble-release.aar: 2180 
Total fields in rxandroidble-release.aar:  976 
Total classes in rxandroidble-release.aar:  510 
AAR size 363kB

Additionally, there is a JAR with 41kB with the shaded Dagger containing 187 methods.

@uKL uKL force-pushed the shaded_dagger branch 2 times, most recently from bfbf257 to e117cb3 Compare December 21, 2017 11:19
@uKL uKL changed the title WIP: Shaded Dagger dependency, fixes #342 Shaded Dagger dependency, fixes #342 Dec 21, 2017
Copy link
Owner

@dariuszseweryn dariuszseweryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 All good.
I would like to see the difference in the library size and method count after this change.

@dariuszseweryn
Copy link
Owner

I am thinking if this should land in 1.5.0 or 1.4.4... Thoughts?
On one hand the API does not change at all. On the other the we change the dependencies and someone could have used the transitive dagger dependency?

@uKL
Copy link
Collaborator Author

uKL commented Dec 21, 2017

Having used a transitive dependency is an antipattern anyways. The same was with the rxandroid when we removed it.

In case of the dagger, there is a small chance that someone is using it this way due to the compiler dependency. It has to be added directly.

@dariuszseweryn
Copy link
Owner

Antipattern or not-still it can be something that breaks builds.
If we agree that it is just a bugfix then we should go with 1.4.4 but I think we already have some additional changes towards 1.5.0 there

@uKL
Copy link
Collaborator Author

uKL commented Dec 21, 2017

Just to be safe we can go forward to 1.5.0 (we have changes related to operation timeout)

@dariuszseweryn
Copy link
Owner

I am just thinking whether we should temporarily revert operation timeout changes, release 1.4.4 with the shaded dagger and then go back to 1.5.0 with the operation timeout changes applied again

@uKL
Copy link
Collaborator Author

uKL commented Dec 22, 2017

I'm gonna need them soon anyway so we can go with 1.5.0.

@uKL uKL merged commit d72f818 into master Jan 4, 2018
@uKL uKL deleted the shaded_dagger branch January 4, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants