Prepare DisconnectionRouter for concurrent access. #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DisconnectionRouter is storing emitters waiting for information about disconnection in a Queue. This Queue may be accessed concurrently and it was not prepared for this scenario. Additionally there could be a race if an exception would happen when a new emitter would get subscribed. Fixes #441
uKL
reviewed
Jun 13, 2018
| @@ -107,7 +107,7 @@ public void onGattConnectionStateException(BleGattException disconnectedGattExce | |||
| onExceptionOccurred(disconnectedGattException); | |||
| } | |||
|
|
|||
| private void onExceptionOccurred(BleException exception) { | |||
| private synchronized void onExceptionOccurred(BleException exception) { | |||
| if (exceptionOccurred == null) { | |||
There was a problem hiding this comment.
Maybe we could use AtomicReference instead?
There was a problem hiding this comment.
Not sure if this would be sufficient for this use-case as the race may if a new observer is subscribing to asValueOnlyObservable after the check for exceptionOccured is made
uKL
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisconnectionRouter is storing emitters waiting for information about disconnection in a Queue. This Queue may be accessed concurrently and it was not prepared for this scenario. Additionally there could be a race if an exception would happen when a new emitter would get subscribed.
Fixes #441