Mock structure changes #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another valuable PR. I would like to address #703 first as there are some changes that raise my concerns and continue with this one after. |
Merged
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMock.java
|
Today I have little time. Either way I plan to get back to this PR Tomorrow |
dariuszseweryn
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on PR #703 but I did a new PR as they are not really related, however merging this PR instead would mean further API deprecations are not required between the two PRs.
The main purpose of this PR is to allow users to provide their own
RxBleConnectionMockinstance, so they can customise the behaviour of the mock during connection. It also makes the interfaces a bit cleaner, and moves theRxBleDeviceMockbuilder inside that class which is a more appropriate location.All deprecated APIs are marked as such and continue to work, and legacy unit tests have been added to ensure that.