Add isConnectable to ScanResult #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ble-isconneable
|
|
|
I decided to fork this project so we can maintain it more actively and merge PRs. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. If you want to submit this PR there I will review. |
|
I have effectively merged this PR and released as |
…le. Introduced injectable IsConnectableChecker. Updated java sample.
dariuszseweryn
approved these changes
May 21, 2022
|
Thanks! When are you planning to release new version? :) |
|
You can preview on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I finished implementation by #689 and tested on many devices .
Code review MR suggested: IsConnectableStatus ✅
After discussion on original MR, author added
isLegacy, which is INCORRECT. So I removed it. isLegacy can be true for peripheral devices but it is independent on isConnectable.We tested the behaviour on many devices (A7 to A12) and it works correctly.