-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to blazor in the client #3254
Comments
I've found the Could you please remind me the issues that I can address? @pbiggar Many in the TODO list here seem only actionable by you, besides the rollbar one which I'll think/look through. I recall that there were some perf. concerns in particular, but forget where. |
I've reordered them and marked the one that I think only I can do. To switch integration tests, you would add the setting here. (separately, I just realized integration tests are running on port 8000 by default, we should be safe to switch the default (see The issue that I expect to come up is that blazor is so slow to initialize that the integration tests will be hard to make work. That slowness is a real issue, and potentially blocking. The issue to solve it is #3168 The changelog is in the docs repo, maybe make a PR saying that it will happen and we can update when we switch the default? Btw, feel free to make new issues for any of these if you prefer. |
relevant bug: #3486 |
Small check-in here; working on this in #3485. Basic transition is set up there, and remaining work at this point is:
After that point, I'll have to hand off to Paul to test with various user canvases. |
Quick link for benchmarking: https://benchmarkdotnet.org/articles/samples/IntroWasm.html |
Catching up with some Slack threads, the remaining things to do here are:
[1] I managed to hit a 404 when loading
Relevantly, the OCaml equivalent not doesn't exclude the blazor folder from things it expects to be hashed I'm guessing the thing to do here will be to either change |
I think I must have been confused when I was adding those files. I think hashing them is the way to go, and what we have working in OCaml is probably right. |
I managed to reproduce the error:
And it seems to happen when part of the load time's out: Unclear why these loads time out, but this happens in about 1/4 of the times I refresh. |
I continue to be unable to repro the blazor load problems. I've tried multiple machines, with and without network throttling, with and without network caching. |
Just the load issues from this comment, right? #3254 (comment) |
Yes. I'm continuing to work on the file hashing issue and cancelling analysis requests when new ones come in. |
Amazing. Suddenly I can repro on my laptop. That said, getting a bit burnt on Blazor work, so just going to focus on the other 2 tasks for now. |
OK, so you're taking #3589, or did you want to drop it for now? |
I'll drop it for now. Just funny timing. |
Relates to #3642 |
@pbiggar - your idea to create an absolutely-minimal AOT build, get that working (callable from JS), and un-delete things slowly until we find the breaking point hadn't occurred to me before. I'm happy to pursue that solo after my current task (or later), or we can pair on it like you mentioned. Mostly just recording the idea here as a reminder. |
I'll be unavailable except sporadicly the next week, so better to go alone. Ping me if you'd like to discuss though, I'll have some availability. |
I'd suggest that you use the official Blazor js files, not our custom ones |
Hmm, I'm not sure how. Are your referring to BlazorWorker? I thought we had to adjust/merge a bunch of files to make it work for our (non-UI) use case? |
Yeah, but for bug-hunting that doesn't matter. We don't need to ship the outcome, just find where things break. I'd suggest editing ui.html to use their blazorworker.js instead of ours, and it's not really important if it's in the background or not for now. So when a trace comes in, it would run it in the foreground instead I guess. |
OK I'll have to look into that and follow up. Is that suggestion based on the chance that our BlazorWorker is somehow the issue causing AOT builds to fail? |
Hopefully merging this later today.
|
The text was updated successfully, but these errors were encountered: