Add clippy and rustfmt to Rust build #486
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #420 this adds clippy (style checks) and rustfmt (code formatting check) to the Rust build.
Details:
cargo fmt
is actually very quick (sub-second on my machine) so it'd be entirely feasible to run it in dev too, but the dev use case is better served by editor integration, and anyway for quick feedback I'd rather see if my code compiles and passes tests before fixing possible formatting errors.N.B. this PR is based on #478 (for the sake of having some non-trivial code to check) - once that merges I'll rebase this branch and change the base of this PR to master.