Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UserTypes, -Consts, and -Fns in favor of their Package equivalents #5356

Merged

Conversation

StachuDotNet
Copy link
Member

@StachuDotNet StachuDotNet commented Apr 21, 2024

  • removes
    • FQTypeName.Package, UserType
    • FQConstantName.Package, UserConstant
    • FQFnName.Package, UserFn
    • the ability to store those^ in our SQL DB
  • anywhere where those things were used, the Package equivalents are now used
  • as such, the "Program" type in RuntimeTypes became a lot thinner
  • tidies both F# and Dark NameResolvers accordingly
  • backfills some Dark WrittenTypesToDark work, along with some ProgramTypes pretty-printing
  • tidies Dark Builtin.debug to behave more like the debuG we have in F#
  • renames SourceRange to Range in a few places, as I noticed some tests were failing

This is towards a larger effort in Package Manager work.

@StachuDotNet StachuDotNet force-pushed the remove-user-types-consts-and-fns branch 8 times, most recently from b9fd49e to ea5e496 Compare April 26, 2024 16:37
@StachuDotNet StachuDotNet changed the title wip: remove user types, consts, and fns Remove UserTypes, -Consts, and -Fns in favor of their Package equivalents Apr 26, 2024
@StachuDotNet
Copy link
Member Author

note to self: remember to test that the CLI is still working alright

@StachuDotNet StachuDotNet force-pushed the remove-user-types-consts-and-fns branch from ea5e496 to 3a2075c Compare April 26, 2024 17:51
@StachuDotNet
Copy link
Member Author

the TODOs outlined above are the only remaining work here - planning on wrapping this up sometime tomorrow

@StachuDotNet StachuDotNet force-pushed the remove-user-types-consts-and-fns branch from 3a2075c to dd2ccf7 Compare April 30, 2024 22:09
@StachuDotNet StachuDotNet force-pushed the remove-user-types-consts-and-fns branch from dd2ccf7 to 27b8fef Compare April 30, 2024 22:43
@StachuDotNet StachuDotNet marked this pull request as ready for review April 30, 2024 22:43
@StachuDotNet StachuDotNet merged commit be65827 into darklang:main Apr 30, 2024
7 checks passed
@StachuDotNet StachuDotNet deleted the remove-user-types-consts-and-fns branch May 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant