-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added left margin adjustment in config #653
Open
sophieball
wants to merge
1
commit into
darknessomi:master
Choose a base branch
from
sophieball:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kigawas
pushed a commit
that referenced
this pull request
Aug 26, 2020
* mac专用版本1.0 * mac专用版本1.0 * 1.0安装 * 修复首次进评论的bug,提高主循环效率 * 修复快速按下一首多个子进程bug * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 修复线程混乱问题增加数字跳转快捷键 * 增加显示颜色自定义,按键映射,使用定时器实现自动关闭功能;修复搜索按键功能映射错误;发现快速切换时会播放多首音乐 * 0.1 * 0.1 * 0.2 * 0.2 * 0.2 * Fix comments bug. * Fix comments bug. * Fix comments bug. * Fix comments bug. * Optimize align of comments. * Optimize align of comments. * Optimize align of comments. * Optimize for someone who write ':' in their comments. * Fix comcomments. * Fix comcomments. * Fix comcomments. * Update README.md * Remove DS_Store. * Fix keymap. * Restore default key bindings. * Restore osdlyrics.py * Remove fucking glyphs. * Fix comments bug. * Merge. * Remove DS_Store. * Merge kwph and wjy. * Change is to ==. * Debug. * Fix bug: fast pressing [ ] will causing multiple play instance. * Remove build_menu_progress. * Optimize branches. * Add a blank in song and fmsongs. * Add mouse support. * Change f to config_file to stop annoying pylint. * Fix notification on Linux. * Move update api from macmusicbox to original one. * Switch to timer. * Fix display of help page. * Add fuzzy search. * Clean code. * Improve performance on urxvt. * Optimize up down key logic. * Format const.py * Update README.md & reset to origin default keymap. * Remove untested platform & add dependencies for fuzzy search. * Don't play music when press num keys. * make num jump usable anywhere. * Fix bug when mouse support is not enabled * Remove num jump when using mouse. * Abitious plan. * Configuration: curses timeout. * Try to optimize responsiveness. * Remove yield latency (?). * Partical plan. * Update README.md * Modifieable menu length * Probably fix of bug darknessomi #816 * Change plan. Mark fixed. * Fix jump logical chaos in comment. * Fix the flash of color of lyrics when press j and k. * Remove some targets & Use more accurate regex match to get timestap from lyrics * Add auto adjust of page length according to terminal size. * Update README.md to keep consist of original one. * Use black to format code. * Use black to format code. * Merge #653. * Fix the bug that if the keymap are not defined in user's json, the program will abort. * Update config file when exit to keep the config file up to dated. * 1. Add notification for the case when url NoneType 2. A possible fix to a possible bug: when fetch the version info sometimes one of latest and version will be 'int' 3. self.margin -> self.left_margin_ratio * Fix double notification after 20 minutes (when urls are updated) & refrese -> refresh (typo). * Margin related feature & bug fix. 1. Add right margin to menu and playinfo 2. adjust scrolling speed of the string * Important bug fix 1. Fix the bug that behavior set by "page_length" will be override as auto adjusted. 2. make the comment section with right margin. * Add process bar with scalable size. * Refracte update_margin(), format code. * Update dependencies. * Update README.md 1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to wrap the shortcut key in README.md 3. Add description to num + key 4. Add bug report for fuzzy search * Update README.md and setup.py 1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to warp the shortcut key in README.md. 3. Add description to num + key. 4. Add bug report for fuzzy search. * Fix lyrics logic bug & black format. * [Bug Fix] Now press 'p' will go to the entry in search target, not search result. Corresponding to bug 3 in #10. * [Bug Fix] Fuzzy search bug 1 in #10 Now the wrapped fuzzy search is disabled. * [Bug Fix] #10 * Fix mistake in setup.py * Update README.md 1. Remove problem & solution 858. 2. Make number key instructions more clear. 3. The path of log file should now obey XDG standard. * [Bug fix] No lyrics in Chinese songs. * [Bug fix] Remove unneccessary code to reduce increasing latency when call space_key_event() * [Bug fix] Fix the bug that when no song is being played, call tune_volume() will abort the application. * [Bug Fix] Fix the bug that sometimes (when refresh urls) the play/pause status in playinfo will be wrong. * Use black to format code. Co-authored-by: wangjianyuan10 <wangjianyuan10@163.com> Co-authored-by: kenhuang <hwp0415229@sina.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #600