This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
Nov 1, 2019
ghost
mentioned this pull request
Nov 1, 2019
Open
I tested |
when will it be ready |
It'll be ready when it's ready :) It's just waiting on time to finish up the rise/transit/set portions. The math isn't hard, I've just been really busy for the last two weeks, and expect to be really busy for the next few. |
I rewrote all of this again, for more accuracy and to support sunrise and set. Will open a new PR. |
ghost
closed this
Mar 26, 2020
ghost
deleted the
ironwallaby/rewrite
branch
March 26, 2020 20:56
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the
astro
library in order to support the planets and stars (in addition to the luminaries, that were already supported). In so doing, it seemed like a reasonable time to rewrite the entire interface.This is not yet complete:
defineGetter
to set cached objects on the local object. This is elegant and convenient, but is a different method more efficient?)