Skip to content
This repository has been archived by the owner on Apr 25, 2020. It is now read-only.

Total rewrite #23

Closed
wants to merge 23 commits into from
Closed

Total rewrite #23

wants to merge 23 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2019

This is a complete rewrite of the astro library in order to support the planets and stars (in addition to the luminaries, that were already supported). In so doing, it seemed like a reasonable time to rewrite the entire interface.

This is not yet complete:

  • Tests need to be written to verify the accuracy and correctness of everything!
    • sun
    • moon
    • planets
    • fixed stars
  • The moon's position is (theoretically) inaccurate, since it's close enough that your position on the surface of the earth matters. We need to apply a correction factor when you go into horizontal coordinates.
  • The moon should include phase, illuminated fraction, etc.
  • Rise/set/transit times should be supported.
  • I just picked a few bright and culturally/historically important stars. Should we add other things, too?
  • There's a lot of room for optimization. (One thing I'm particularly curious of: I'm using defineGetter to set cached objects on the local object. This is elegant and convenient, but is a different method more efficient?)

@ghost ghost self-assigned this Nov 1, 2019
@ghost ghost mentioned this pull request Nov 1, 2019
@ghost
Copy link
Author

ghost commented Nov 15, 2019

I tested defineProperty and it's quite slow. I'll switch to other ways of doing it.

@YOEL311
Copy link

YOEL311 commented Dec 5, 2019

when will it be ready
Can I help with something?

@ghost
Copy link
Author

ghost commented Dec 5, 2019

It'll be ready when it's ready :)

It's just waiting on time to finish up the rise/transit/set portions. The math isn't hard, I've just been really busy for the last two weeks, and expect to be really busy for the next few.

@ghost
Copy link
Author

ghost commented Mar 26, 2020

I rewrote all of this again, for more accuracy and to support sunrise and set. Will open a new PR.

@ghost ghost closed this Mar 26, 2020
@ghost ghost deleted the ironwallaby/rewrite branch March 26, 2020 20:56
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant