lua preferences: do not add enum default value as additional item #11175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add a lua script preference setting of type "enum" (combobox) I noticed that the default value is set as an additional selection value.
According to the preferenceExamples.lua script, the values should include the default value:
("Enum 1" is in the values and additionally as default value).
Doing so, the default value will be in the preferences drop down selection twice.
As it seems that no script (except the examples) from the distro currently uses the enum, I guess it's ok to change the behavior so that the default value is stored but not added to the list for the combobox.
The alternative is to omit the default value in the values enumeration. But than it will be impossible to have a "ordered" list where the default is not the first item.
As I do not have an overview of the entire impact of this small change, please check twice before merging. Thank you!