-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style shortcuts translated and hierarchicalised in prefs/dialog #18332
Conversation
I haven't seen this while I was finalizing my PR :) |
Tested, for the preference it is all good. The only remaining issue is the non translated name displayed to the user via the control log in |
279e2f7
to
27c95ce
Compare
27c95ce
to
0b01d9d
Compare
Remaining issue with style toast resolved in first commit Second commit adds hierarchical menus for processing module presets and also changes their names to l10n format so that shortcuts don't break when changing languages. (For now, I haven't attempted to retain existing shortcuts so they'll all be dropped). There are remaining issues, especially where treeviews and dialogs assume there is no difference between the internal and displayed/translated names. So when editing a preset, the translated name is presented, but then when saving that doesn't match the existing preset (if there are multiple levels divided by |) because the translated name contains " | " rather than just "|" (space before and after). Another issue, that is dealt with, but with consequences, is that internally contextualized translations (C_() or NC_()) are represented by "context|text". This is how Gtk does it. But | is now also used for hierarchies. So internally a context marker is changed to ^ and later changed back just before translating. If a user intentionally puts ^ in a string marked for translation with l10n they may not realise this will be interpreted as a context marker. |
0b01d9d
to
23a3fc2
Compare
On second thought, just introducing the hierarchical submenus for processing module presets. In the module hamburger menu only, not for the "favorite presets", because I think people would insert | if they have many per-module presets, but then don't want that to lead to a long list of one-item submodules in the favorite menu (where they would anyway only put the most-used ones). This does not include the translation work on presets yet (i.e. to make the internal representation, which is linked to shortcuts, be independent of the chosen language so that shortcuts don't break when switching. That's still a more involved change that requires a lot of testing and feedback. @TurboGit I think this is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Release notes:
|
fixes #18325
while testing this I'm getting bitten quite badly by #18196; only a part of the style tree ends up getting localized. Switching off setlocale in the opencl code fixes it.
Renaming or deleting presets (and presumably styles) while in non-English ends up not finding/removing the previous associated action. Still needs fixing.