Wayland: add DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE to disable TitleBar for Unite compatibility #19694
+46
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtyrtov
changed the title
1 task
…ed hint This commit adds multiple options for controlling window decorations on Wayland: 1. Prefer server-side decorations (SSD) over client-side decorations (CSD) 2. Add hide-titlebar-when-maximized hint for better compatibility with GNOME extensions like Unite 3. Add environment variable DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE to opt-out of HeaderBar usage when maximized (for Unite compatibility) 4. Add darktablerc option 'hide_titlebar_on_maximize' for persistent configuration These changes improve window behavior on Wayland, especially with tiling window managers and GNOME Shell extensions.
vtyrtov
force-pushed
the
pr/wayland-titlebar-hint-clean
branch
from
39f9d6a to
7d23b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19806
Summary
Keep the original Wayland behavior from master (GtkHeaderBar / client-side decorations). Add a single opt-in flag so GNOME Shell extensions (e.g. Unite) can hide the titlebar cleanly and reclaim space.
Behavior
Default (Wayland): GtkHeaderBar shown, unchanged from master.
Opt-in compatibility mode:
Enable via DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE=1 (or ui/hide_titlebar_on_maximize=true)
Effect: no GtkHeaderBar, server-side decorations used, gtk_window_set_hide_titlebar_when_maximized(TRUE). Allows WM/extension to hide titlebar without a gap.
Implementation
Added conditional logic in [gtk.c]
Testing
Default: header bar visible as before.
With DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE=1: Unite hides titlebar; window resizes (no top gap).