Avoid crash at exit due to race condition #19872
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to get a crash in a background job such as _control_write_sidecars_job_run on exit due to an attempt by the job to check whether the control system is still running with dt_control_running() *after* darktable.control has been freed. While this commit is not a total fix, it reduces the vulnerable time window from milliseconds to nanoseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to get a crash in a background job such as
_control_write_sidecars_job_runon exit due to an attempt by the job to check whether the control system is still running with dt_control_running() after darktable.control has been freed. I've experienced this twice since switching my production copy from 5.2.1 to master about three weeks ago.While this commit is not a total fix, it reduces the vulnerable time window from milliseconds to nanoseconds.