Fix build error #41
Closed
Fix build error #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Nice, thanks. In fact i was thinking i should just copy over |
Merged
|
I adopted a different approach, see #42. Thank you for pointing out the issue and proposing a fix. |
darosior
added a commit
that referenced
this pull request
Sep 7, 2024
Install python-bip32 from source to avoid #41 from happening again. Unfortunately building coincurve on MacOS keeps failing for esoteric reasons and i don't have infinite time, so on MacOS first install coincurve wheels before installing python-bip32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
import bip32insetup.pybreaks build from source due to circular dependency (base58 is not installed).Solution:
Separate
__version__to another file.