Update testing strategy #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
commented
Aug 9, 2023
jmesnil
commented
- Rely on the provisioned server + deployments to run the integration tests
- Use a single managed Arquillian container to run the tests
- Do not use profiles for testing, with this settings, there is no reason that integration tests should be skipped.
jmesnil
force-pushed
the
darranl-WFLY-17651
branch
from
f707947 to
a2fe470
Compare
jmesnil
commented
Aug 9, 2023
| @@ -3,14 +3,15 @@ | |||
| #set( $symbol_escape = '\' ) | |||
| package org.wildfly.security.examples.test; | |||
There was a problem hiding this comment.
@darranl That's not related to the intent of this PR but the generated example should also use the package instead of this hard-coded name
jmesnil
force-pushed
the
darranl-WFLY-17651
branch
from
a2fe470 to
a5a3022
Compare
* Rely on the provisioned server + deployments to run the integration tests * Use a single managed Arquillian container to run the tests * Do not use profiles for testing, with this settings, there is no reason that integration tests should be skipped. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
darranl-WFLY-17651
branch
from
a5a3022 to
68f1ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.