Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: upgrade textual depency to >=0.11.0 release. #11

Closed
wants to merge 1 commit into from

Conversation

UmBsublime
Copy link
Contributor

@UmBsublime UmBsublime commented Feb 28, 2023

I've been using textual-autocomplete with textual 0.12.0 and 0.12.1 and so far no issues to report.

fixes #10

@ofek
Copy link

ofek commented Mar 1, 2023

this would also benefit us greatly so we can upgrade Textual for a bug fix

@UmBsublime
Copy link
Contributor Author

UmBsublime commented Mar 1, 2023

@ofek in the meantime you can fork and update dependencies on your project to use your fork.
Alternatively you can use my fork as a temporary dependency.
With poetry it looks something like:

poetry remove textual-autocomplete
poetry add git+https://github.com:UmBsublime/textual-autocomplete.git

Following that you can bump textual to 0.12.* release

Once this repo updates to 0.12.* you can switch back the dependency to tihs repo

@ofek
Copy link

ofek commented Mar 6, 2023

@UmBsublime Hey, Darren just mentioned in Discord that he actually meant to not hard cap but rather use >=0.11.0. Would you mind changing to that?

@UmBsublime
Copy link
Contributor Author

@ofek I'm on it sometime today ;)

@UmBsublime
Copy link
Contributor Author

This pr is getting quite messy (sorry) , let me know If you prefer me to recreate it with a single commit and proper PR message.
Also, not sure if you want poetry.lock to be included in the PR.

@UmBsublime UmBsublime changed the title Changed: upgrade textual to 0.12.0 release Changed: upgrade textual depency to >=0.11.0 release. Mar 6, 2023
@UmBsublime
Copy link
Contributor Author

I'll close this PR to instead introduce #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textual-autocomplete breaks textual-0.12+
2 participants