Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only show dropdown if input widget currently has focus #8

Merged
merged 2 commits into from
Mar 27, 2023
Merged

feat: only show dropdown if input widget currently has focus #8

merged 2 commits into from
Mar 27, 2023

Conversation

jtyers
Copy link
Contributor

@jtyers jtyers commented Feb 24, 2023

Fixes #7 by only setting self.display if the input widget has focus

@jtyers
Copy link
Contributor Author

jtyers commented Feb 24, 2023

I do wonder if it's a better design to watch the input widget's has_focus attr and set self.display in there instead, so that moving between inputs shows completions automagically as I focus different inputs. What do you think?

@darrenburns darrenburns merged commit dd74222 into darrenburns:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown displays even if input does not have focus
2 participants
@jtyers @darrenburns