Skip to content

Do not alter metadata keys #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Do not alter metadata keys #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f191d3
We do not want to alter the metadata keys.
darrencauthon Nov 15, 2017
5aa75f2
Refactor.
darrencauthon Nov 15, 2017
f2694d8
Rename.
darrencauthon Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/SparkPost.Tests/DataMapperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,16 @@ public void metadata()
.CastAs<IDictionary<string, object>>()[key].ShouldEqual(value);
}

[Test]
public void do_not_alter_the_keys_passed_to_metadata()
{
var key = "TEST";
var value = Guid.NewGuid().ToString();
transmission.Metadata[key] = value;
mapper.ToDictionary(transmission)["metadata"]
.CastAs<IDictionary<string, object>>()[key].ShouldEqual(value);
}

[Test]
public void do_not_include_empty_metadata()
{
Expand Down
13 changes: 9 additions & 4 deletions src/SparkPost/DataMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,8 @@ public virtual IDictionary<string, object> ToDictionary(Transmission transmissio
{
var data = new Dictionary<string, object>
{
["substitution_data"] =
transmission.SubstitutionData != null && transmission.SubstitutionData.Keys.Any()
? transmission.SubstitutionData
: null,
["substitution_data"] = AlterThisDictionaryToBePassedToSparkpost(transmission.SubstitutionData),
["metadata"] = AlterThisDictionaryToBePassedToSparkpost(transmission.Metadata),
["recipients"] = transmission.ListId != null
? (object) new Dictionary<string, object> {["list_id"] = transmission.ListId}
: transmission.Recipients.Select(ToDictionary)
Expand All @@ -100,6 +98,13 @@ public virtual IDictionary<string, object> ToDictionary(Transmission transmissio
return result;
}

private static IDictionary<string, object> AlterThisDictionaryToBePassedToSparkpost(IDictionary<string, object> dictionary)
{
return dictionary != null && dictionary.Keys.Any()
? dictionary
: null;
}

public virtual IDictionary<string, object> ToDictionary(Recipient recipient)
{
return WithCommonConventions(recipient, new Dictionary<string, object>()
Expand Down