[WIP] Issue #50 Webhook event classes #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZA1 How do you feel about this? Do you think it is ready to go? I didn't mean to ignore your work here, I've just not had a good opportunity to check the work myself. I haven't set up an endpoint, so I haven't had a chance to run them for myself. I'm sorry for the time it's taken. What are your thoughts on this code? Have you used it yourself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial stab at issue #50.
I have put the classes in the SparkPost.WebHooks namespace. I am not 100% convinced that this is the right name for them.
Also I have put attributes on all the property names so they will be deserialized no matter what conventions have been set up for Newtonsoft.Json.