Skip to content

feature: add custom properties for dialog #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature: add custom properties for dialog #64

wants to merge 1 commit into from

Conversation

walle19
Copy link

@walle19 walle19 commented Apr 28, 2020

Feature
To have custom properties for Dialog

Scenario
A dev can add property such as persistent if the requirement is to close dialog via button action only.

Update

  • Added the property attribute
  • Added dialog custom property to example as well

@PRAJINPRAKASH
Copy link

@darrenfang Please review this

@permanar
Copy link

We need the default persistent props for the dialog!👍

@permanar permanar mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walle19 @PRAJINPRAKASH @permanar