Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Tests break in Dart 1.5.x but not 1.4.x or 1.6.x #1219

Closed
chirayuk opened this issue Jul 10, 2014 · 2 comments
Closed

Tests break in Dart 1.5.x but not 1.4.x or 1.6.x #1219

chirayuk opened this issue Jul 10, 2014 · 2 comments
Milestone

Comments

@chirayuk
Copy link
Contributor

Just run css_animate_spec.dart's main() more than once and you'll see a failure in ng_model_spec.dart.  The repro case is in commit chirayuk@548b2d6 with the corresponding failing Travis build for current at https://travis-ci.org/chirayuk/angular.dart/jobs/29563090.  This only happens in the Dartium for Dart 1.5.x – not in Dart 1.4.x or Dart 1.6.x.  I haven't been able to isolate this bug but I'm working around it by disabling the test temporarily for Dart 1.5.x.

@chirayuk chirayuk added this to the 0.13.0 milestone Jul 10, 2014
@chirayuk
Copy link
Contributor Author

I've worked around it for commit b3f2e6c by selectively disabling tests in animation_optimizer_spec.dart and css_animate_spec.dart.

chirayuk added a commit to chirayuk/angular.dart that referenced this issue Jul 10, 2014
chirayuk added a commit that referenced this issue Jul 10, 2014
chirayuk added a commit that referenced this issue Jul 10, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@vsavkin vsavkin modified the milestones: 0.14.0, 0.13.0 Jul 24, 2014
@rkirov rkirov modified the milestones: 0.14.0, 0.15.0 Aug 22, 2014
@chirayuk
Copy link
Contributor Author

chirayuk commented Oct 2, 2014

Fixed in #1497 by @juliemr

@chirayuk chirayuk closed this as completed Oct 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants