This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Angular's transformers do not follow Barbacks asset resolution. #1651
Comments
TedSander
pushed a commit
to TedSander/angular.dart
that referenced
this issue
Jan 18, 2015
Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes dart-archive#1651
TedSander
pushed a commit
to TedSander/angular.dart
that referenced
this issue
Jan 27, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes dart-archive#1649, dart-archive#1651
rkirov
pushed a commit
that referenced
this issue
Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes #1649, #1651
rkirov
pushed a commit
that referenced
this issue
Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes #1649, #1651
rkirov
pushed a commit
that referenced
this issue
Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes #1649, #1651
rkirov
pushed a commit
that referenced
this issue
Feb 2, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes #1649, #1651
rkirov
pushed a commit
that referenced
this issue
Feb 2, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other transformers. This allows other transformers such as the ExpressionGenerator and later the TemplateCacheGenerator to find relative resources. Fixes asset resolution according to Barback rules which are defined here: http://goo.gl/YDMRc2 specifically library assets are defined with packages being in the URI and all other resources are considered web resources. Closes #1649, #1651
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Barbacks rules for asset resolution are defined here: http://goo.gl/YDMRc2. The expression generator tests use lib/test.html as URIs for resolution. In practice these URIs would not be used by the pub system. Instead all library resources would have packages in the URI. In addition the current code does not handle web URIs correctly. Any URI which do not contain packages/ are considered web resources. These resources will not start with web. Yet when creating the AssetID the web location must be prepended to find the resource.
The text was updated successfully, but these errors were encountered: