Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Scope.runAsync should handle all the microtasks #920

Open
jbdeboer opened this issue Apr 16, 2014 · 2 comments
Open

Scope.runAsync should handle all the microtasks #920

jbdeboer opened this issue Apr 16, 2014 · 2 comments

Comments

@jbdeboer
Copy link
Contributor

There is a bad interaction between NgZone and Scope, where if Scope.digest created a microtask, NgZone will run it and then force a brand-new Scope.digest run.

This causes too mach Scope.digests and can lead to infinite loops.

The best approach we have so far is to have Scope handle all the microtasks in its runAsync queue.

@mvuksano
Copy link
Contributor

@jbdeboer Can you tell me if this is similar/same as #976 (mhevery@2675da0)? If it's not same, I have a feeling it might be very similar.

@jbdeboer
Copy link
Contributor Author

It is; I have code for this issue, but haven't got around to writing the tests for Scope -- I suspect that the whole test suite should be refactored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants