This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(ng-repeat): handle the ref changing to null and back #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in commit 09871cb. If the ng-repeat expression changed from an iterable to a null, ng-repeat would not notice it. This would cause further bugs as it would not reset its state and the ref became a collection again (i.e. once out of sync, it was gone forever.) Closes dart-archive#1015
| _viewPort.remove(row.view); | ||
| leftInDom.removeAt(domLength - 1 - index); | ||
| }); | ||
| if (changes == null) { |
There was a problem hiding this comment.
Wouldn't it be even simpler to move this check at the beginning of this method ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in commit 09871cb.
If the ng-repeat expression changed from an iterable to a null,
ng-repeat would not notice it. This would cause further bugs as it
would not reset its state and the ref became a collection again (i.e.
once out of sync, it was gone forever.)
Closes #1015