Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

dccd updates (for iterables) #1129

Closed
wants to merge 2 commits into from
Closed

dccd updates (for iterables) #1129

wants to merge 2 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 9, 2014

Commits:

  1. fix False positive in collections dccd  #1105
  2. update some comments as they will not be applicable to JS only once the linked issue is merged in Dart,
  3. some renaming to ease comprehesion

@vicb vicb added cla: yes and removed cla: no labels Jun 9, 2014
@vicb
Copy link
Contributor Author

vicb commented Jun 9, 2014

merged on 0609

@vicb vicb closed this Jun 9, 2014
@vicb vicb reopened this Jun 9, 2014
@vicb
Copy link
Contributor Author

vicb commented Jun 13, 2014

Only the first commit has been merged to the master branch other will go to the staging branch

@vicb vicb added this to the 0.14.0 milestone Jun 25, 2014
@vicb
Copy link
Contributor Author

vicb commented Jul 24, 2014

This PR (minor updates to docs + code) is ready to be merged (the first commit has been dropped from this PR as it has already been merged)

vicb added a commit that referenced this pull request Jul 24, 2014
@vicb @chirayuk
refactor(dccd): some renaming to clarify the intent
d97788c 
Closes #1129
@vicb vicb closed this in 0d7124a Jul 24, 2014
@chirayuk
Copy link
Contributor

FYI, I skipped the first commit – doc(dccd): update some comments.  It was wrong and did not apply cleanly.

vicb added a commit that referenced this pull request Jul 29, 2014
@vicb @chirayuk
refactor(dccd): some renaming to clarify the intent
1ae4a78 
Closes #1129
vicb added a commit that referenced this pull request Jul 29, 2014
@vicb @chirayuk
refactor(dccd): some renaming to clarify the intent
a10173b 
Closes #1129
vicb added a commit that referenced this pull request Jul 29, 2014
@vicb @chirayuk
refactor(dccd): some renaming to clarify the intent
e538951 
Closes #1129
vicb added a commit that referenced this pull request Jul 29, 2014
@vicb @chirayuk
refactor(dccd): some renaming to clarify the intent
42ed6a8 
Closes #1129
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
api: no-change cla: yes type: chore
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

False positive in collections dccd
3 participants
@vicb @chirayuk @mhevery