This repository was archived by the owner on Feb 22, 2018. It is now read-only.
[WIP] perf(View): Improve View instantiation speed and memory consumption. #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,8 +36,10 @@ packages: | |||
| source: hosted | |||
| version: "0.9.2" | |||
| di: | |||
| description: di | |||
| source: hosted | |||
| description: | |||
There was a problem hiding this comment.
I don't think we want to merge this ?
There was a problem hiding this comment.
No we don't not final, work in progress. :-)
This was referenced Jun 26, 2014
vicb
changed the title
| => injector.name == SHADOW_DOM_INJECTOR_NAME ? injector.parent : injector; | ||
| abstract class DirectiveBinder { | ||
| bind(key, {Function toFactory, Factory toFactoryPos, inject, | ||
| Visibility visibility: Visibility.DIRECT_CHILD}); |
There was a problem hiding this comment.
Make this Visibility.LOCAL
There was a problem hiding this comment.
done
On Thu, Jun 26, 2014 at 3:07 PM, Yegor notifications@github.com wrote:
In lib/core/annotation_src.dart:
@@ -2,35 +2,28 @@ library angular.core.annotation_src;
import "package:di/di.dart" show Injector, Visibility;
-RegExp _ATTR_NAME = new RegExp(r'[([^]]+)]$');
-const String SHADOW_DOM_INJECTOR_NAME = 'SHADOW_INJECTOR';
-skipShadow(Injector injector)
- => injector.name == SHADOW_DOM_INJECTOR_NAME ? injector.parent : injector;
+abstract class DirectiveBinder {- bind(key, {Function toFactory, Factory toFactoryPos, inject,
Visibility visibility: Visibility.DIRECT_CHILD});Make this Visibility.LOCAL
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.dart/pull/1178/files#r14269780.
|
When will this be merged? |
jbdeboer
added a commit
that referenced
this pull request
Jul 14, 2014
gradual migration. Originally authored by @yjbanov
jbdeboer
added a commit
that referenced
this pull request
Jul 14, 2014
gradual migration. Originally authored by @yjbanov
Closed
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
…o allow gradual migration. Originally authored by @yjbanov
View contains many injectors which are expensive in both speed and memory. The New DirectiveInjector assumes that there are no more than 10 directives per element and can be a lot more efficient than a array/hash lookup and those it can be faster as well as smaller. This change makes View instantiation speed 4x faster in Dartium VM. BREAKING CHANGE: - Injector no longer supports visibility - The Directive:module instead of returning Module now takes DirectiveModule (which supports visibility) - Application Injector and DirectiveInjector now have separate trees. (The root if DirectiveInjector is ApplicationInjector)
|
@mhevery I have submitted a PR to your repo to update the branch, see Remove usage of (deprecated) probe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View contains many injectors which are expensive in both speed and memory. The
New DirectiveInjector assumes that there are no more than 10 directives
per element and can be a lot more efficient than a array/hash lookup and
those it can be faster as well as smaller. This change makes View
instantiation speed 4x faster in Dartium VM.
BREAKING CHANGE:
DirectiveModule (which supports visibility)
(The root of DirectiveInjector is ApplicationInjector)