Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

[WIP]: MicroMap #1208

Closed
wants to merge 6 commits into from
Closed

[WIP]: MicroMap #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c620a11
feat(MicroMap): An implementation of the Map which initially uses arr…
mvuksano Jul 6, 2014
c7fc8f3
First pass of MicroIterable
mvuksano Jul 10, 2014
3b08e46
Added tests stub
mvuksano Jul 10, 2014
62cb43b
First test
mvuksano Jul 10, 2014
f24a42c
MicroIterable
mvuksano Jul 11, 2014
9169c52
A few more tests
mvuksano Jul 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions lib/change_detection/prototype_map.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,12 @@
part of angular.watch_group;

class PrototypeMap<K, V> implements Map<K,V> {
class PrototypeMap<K, V> extends MicroMap<K,V> {
final Map<K, V> prototype;
final Map<K, V> self = new HashMap();

PrototypeMap(this.prototype);

void operator []=(name, value) {
self[name] = value;
}
V operator [](name) => self.containsKey(name) ? self[name] : prototype[name];
V operator [](name) => containsKey(name) ? super[name] : prototype[name];

bool get isEmpty => self.isEmpty && prototype.isEmpty;
bool get isNotEmpty => self.isNotEmpty || prototype.isNotEmpty;
// todo(vbe) include prototype keys ?
Iterable<K> get keys => self.keys;
// todo(vbe) include prototype values ?
Iterable<V> get values => self.values;
int get length => self.length;

void forEach(fn) {
// todo(vbe) include prototype ?
self.forEach(fn);
}
V remove(key) => self.remove(key);
clear() => self.clear;
// todo(vbe) include prototype ?
bool containsKey(key) => self.containsKey(key);
// todo(vbe) include prototype ?
bool containsValue(key) => self.containsValue(key);
void addAll(map) {
self.addAll(map);
}
// todo(vbe) include prototype ?
V putIfAbsent(key, fn) => self.putIfAbsent(key, fn);
bool get isEmpty => count == 0 && prototype.isEmpty;
bool get isNotEmpty => count != 0 || prototype.isNotEmpty;
}
1 change: 1 addition & 0 deletions lib/change_detection/watch_group.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
library angular.watch_group;

import 'package:angular/change_detection/change_detection.dart';
import 'package:angular/collection/micro_map.dart';
import 'dart:collection';

part 'linked_list.dart';
Expand Down
281 changes: 281 additions & 0 deletions lib/collection/micro_iterable.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,281 @@
library angular.collection;

import 'dart:collection';

const int _LIST_ELEMENTS = 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused ?


class MicroIterable<E> extends Object with IterableMixin implements Iterable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be class MicroIterable<E> extends IterableBase<E> ?

var _element0;
var _element1;
var _element2;
var _element3;
var _element4;
var _element5;
var _element6;
var _element7;
var _element8;
var _element9;
var _element10;
var _element11;
var _element12;
var _element13;
var _element14;
var _element15;
var _element16;
var _element17;
var _element18;
var _element19;
var _count = 0;

MicroIterable(e0, e1, e2, e3, e4, e5, e6, e7, e8, e9, e10, e11, e12, e13, e14, e15, e16, e17, e18, e19, count) {
_element0 = e0 ;
_element1 = e1 ;
_element2 = e2 ;
_element3 = e3 ;
_element4 = e4 ;
_element5 = e5 ;
_element6 = e6 ;
_element7 = e7 ;
_element8 = e8 ;
_element9 = e9 ;
_element10 = e10;
_element11 = e11;
_element12 = e12;
_element13 = e13;
_element14 = e14;
_element15 = e15;
_element16 = e16;
_element17 = e17;
_element18 = e18;
_element19 = e19;
_count = count;
}

Iterator<E> get iterator => new _ListIterator(this);

bool contains(Object element) {
if (_element0 == element) return true;
else if (_element1 == element) return true;
else if (_element2 == element) return true;
else if (_element3 == element) return true;
else if (_element4 == element) return true;
else if (_element5 == element) return true;
else if (_element6 == element) return true;
else if (_element7 == element) return true;
else if (_element8 == element) return true;
else if (_element9 == element) return true;
else if (_element10 == element) return true;
else if (_element11 == element) return true;
else if (_element12 == element) return true;
else if (_element13 == element) return true;
else if (_element14 == element) return true;
else if (_element15 == element) return true;
else if (_element16 == element) return true;
else if (_element17 == element) return true;
else if (_element18 == element) return true;
else if (_element19 == element) return true;
else return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can drop all the elses from this method

}

String join([String separator = ""]) {
if (_element0 == null) return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that the iterable could not hold null values.

This is a limitation vs the a regular iterable (I have not followed all the discussions, may be this is by design ?)

var joined = '${_element0}';
if (_element1 == null) return joined;
joined = '$joined$separator$_element1';
if (_element2 == null) return joined;
joined = '$joined$separator$_element2';
if (_element3 == null) return joined;
joined = '$joined$separator$_element3';
if (_element4 == null) return joined;
joined = '$joined$separator$_element4';
if (_element5 == null) return joined;
joined = '$joined$separator$_element5';
if (_element6 == null) return joined;
joined = '$joined$separator$_element6';
if (_element7 == null) return joined;
joined = '$joined$separator$_element7';
if (_element8 == null) return joined;
joined = '$joined$separator$_element8';
if (_element9 == null) return joined;
joined = '$joined$separator$_element9';
if (_element10 == null) return joined;
joined = '$joined$separator$_element10';
if (_element11 == null) return joined;
joined = '$joined$separator$_element11';
if (_element12 == null) return joined;
joined = '$joined$separator$_element12';
if (_element13 == null) return joined;
joined = '$joined$separator$_element13';
if (_element14 == null) return joined;
joined = '$joined$separator$_element14';
if (_element15 == null) return joined;
joined = '$joined$separator$_element15';
if (_element16 == null) return joined;
joined = '$joined$separator$_element16';
if (_element17 == null) return joined;
joined = '$joined$separator$_element17';
if (_element18 == null) return joined;
joined = '$joined$separator$_element18';
if (_element19 == null) return joined;
joined = '$joined$separator$_element19';
return joined;
}

List<E> toList({bool growable}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should growable default to true ?

if (growable != null) return new List.from(this, growable: growable);
return new List.from(this);
}

Set<E> toSet() {
Set set = new HashSet();
if (_count == 0) return set;
if (_element0 != null) set.add(_element0 );
if (_count == 1) return set;
if (_element1 != null) set.add(_element1 );
if (_count == 2) return set;
if (_element2 != null) set.add(_element2 );
if (_count == 3) return set;
if (_element3 != null) set.add(_element3 );
if (_count == 4) return set;
if (_element4 != null) set.add(_element4 );
if (_count == 5) return set;
if (_element5 != null) set.add(_element5 );
if (_count == 6) return set;
if (_element6 != null) set.add(_element6 );
if (_count == 7) return set;
if (_element7 != null) set.add(_element7 );
if (_count == 8) return set;
if (_element8 != null) set.add(_element7 );
if (_count == 9) return set;
if (_element9 != null) set.add(_element8 );
if (_count == 10) return set;
if (_element10 != null) set.add(_element10);
if (_count == 11) return set;
if (_element11 != null) set.add(_element11);
if (_count == 12) return set;
if (_element12 != null) set.add(_element12);
if (_count == 13) return set;
if (_element13 != null) set.add(_element13);
if (_count == 14) return set;
if (_element14 != null) set.add(_element14);
if (_count == 15) return set;
if (_element15 != null) set.add(_element15);
if (_count == 16) return set;
if (_element16 != null) set.add(_element16);
if (_count == 17) return set;
if (_element17 != null) set.add(_element16);
if (_count == 18) return set;
if (_element18 != null) set.add(_element18);
if (_count == 19) return set;
if (_element19 != null) set.add(_element19);
return set;
}

int get length => _count;

bool get isEmpty => _count == 0;

bool get isNotEmpty => _count != 0;

E get first {
if (_element0 != null) return _element0 ;
if (_element1 != null) return _element1 ;
if (_element2 != null) return _element2 ;
if (_element3 != null) return _element3 ;
if (_element4 != null) return _element4 ;
if (_element5 != null) return _element5 ;
if (_element6 != null) return _element6 ;
if (_element7 != null) return _element7 ;
if (_element8 != null) return _element8 ;
if (_element9 != null) return _element9 ;
if (_element10 != null) return _element10;
if (_element11 != null) return _element11;
if (_element12 != null) return _element12;
if (_element13 != null) return _element13;
if (_element14 != null) return _element14;
if (_element15 != null) return _element15;
if (_element16 != null) return _element16;
if (_element17 != null) return _element17;
if (_element18 != null) return _element18;
if (_element19 != null) return _element19;
}

E get last {
if (_element19 != null) return _element19;
if (_element18 != null) return _element18;
if (_element17 != null) return _element17;
if (_element16 != null) return _element16;
if (_element15 != null) return _element15;
if (_element14 != null) return _element14;
if (_element13 != null) return _element13;
if (_element12 != null) return _element12;
if (_element11 != null) return _element11;
if (_element10 != null) return _element10;
if (_element9 != null) return _element9 ;
if (_element8 != null) return _element8 ;
if (_element7 != null) return _element7 ;
if (_element6 != null) return _element6 ;
if (_element5 != null) return _element5 ;
if (_element4 != null) return _element4 ;
if (_element3 != null) return _element3 ;
if (_element2 != null) return _element2 ;
if (_element1 != null) return _element1 ;
if (_element0 != null) return _element0 ;
}

E get single {
if (length == 0) throw "No elements";
if (length > 1) throw "More then one element";
return elementAt(0);
}

E elementAt(int index) {
if (index == 0 ) return _element0 ;
if (index == 1 ) return _element1 ;
if (index == 2 ) return _element2 ;
if (index == 3 ) return _element3 ;
if (index == 4 ) return _element4 ;
if (index == 5 ) return _element5 ;
if (index == 6 ) return _element6 ;
if (index == 7 ) return _element7 ;
if (index == 8 ) return _element8 ;
if (index == 9 ) return _element9 ;
if (index == 10) return _element10;
if (index == 11) return _element11;
if (index == 12) return _element12;
if (index == 13) return _element13;
if (index == 14) return _element14;
if (index == 15) return _element15;
if (index == 16) return _element16;
if (index == 17) return _element17;
if (index == 18) return _element18;
if (index == 19) return _element19;
}
}

class _ListIterator<E> implements Iterator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class _ListIterator<E> implements Iterator<E> ?


MicroIterable _iterable;
var _length;
var _current;
var _cursor = 0;

_ListIterator(iterable): _iterable = iterable, _length = iterable.length, _cursor = 0;

bool moveNext() {
int length = _iterable.length;
if (_length != length) {
throw new ConcurrentModificationError(_iterable);
}
if (_cursor >= length) {
_current = null;
return false;
}
_current = _iterable.elementAt(_cursor);
_cursor++;
return true;
}

E get current => _current;

}
Loading