Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Rebased #1346: feat(TestBed): add whitespace handling to compile #1445

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/mock/test_bed.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ class TestBed {
*/
List<Element> toNodeList(html) {
var div = new DivElement();
div.setInnerHtml(html, treeSanitizer: new NullTreeSanitizer());
var sanitizedHtml = _handleWhitespace(html);
div.setInnerHtml(sanitizedHtml, treeSanitizer: new NullTreeSanitizer());
var nodes = [];
for (var node in div.nodes) {
nodes.add(node);
Expand Down Expand Up @@ -99,4 +100,12 @@ class TestBed {
}

getScope(Node node) => getProbe(node).scope;

String _handleWhitespace(html) {
return html.split('\n')
.map((line) {
var trimmed = line.trim();
return trimmed + (trimmed.isEmpty || trimmed.endsWith('>') ? '' : ' ');})
.join();
}
}
18 changes: 18 additions & 0 deletions test/mock/test_bed_spec.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,24 @@ void main() {
expect(directiveInst.destroyed).toBe(true);
});

it('should handle whitespace cleanly', () {
var root = _.compile('''
<div>
<h1
attr="Hi">
</h1>
</div>
<span
attr2="Bye"

></span>
''');

expect(root).toBeAnInstanceOf(DivElement);
expect(_.rootElements[1]).toBeAnInstanceOf(SpanElement);
expect(_.rootElements.length).toBe(2);
});

});
}

Expand Down