Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

fix(cookies): Make sure Cookies is injectable. #856

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions example/web/todo.dart
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ class TodoController {
serverController.init(this);
}

// workaround for https://github.com/angular/angular.dart/issues/37
dynamic operator [](String key) => key == 'newItem' ? newItem : null;

void add() {
if (newItem.isEmpty) return;

Expand Down
1 change: 1 addition & 0 deletions lib/core_dom/cookies.dart
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ class BrowserCookies {
/**
* Cookies service
*/
@NgInjectableService()
class Cookies {
BrowserCookies _browserCookies;
Cookies(this._browserCookies);
Expand Down
2 changes: 1 addition & 1 deletion lib/tools/transformer/expression_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ final Map<String, Symbol> symbols = ${generateSymbolMap(symbols)};
return '{\n${lines.join(",\n")}\n}';
}

generateSymbolMap(Set<Strings> symbols) {
generateSymbolMap(Set<String> symbols) {
var lines = symbols.map((key) => ' r"${key}": #$key');
return '{\n${lines.join(",\n")}\n}';
}
Expand Down
2 changes: 1 addition & 1 deletion test/io/test_files/templates/main.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
library test_files.main;

import 'package:angular/core/module_internal.dart';
import 'package:angular/core/annotation.dart';
import 'package:angular/tools/template_cache_annotation.dart';

part 'partial.dart';
Expand Down