This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Null safety migration #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable stack traces land
natebosch
reviewed
Mar 17, 2020
| } | ||
|
|
||
| /// The operation controlled by this completer. | ||
| CancelableOperation<T> get operation => _operation; | ||
| CancelableOperation<T> _operation; | ||
| late final CancelableOperation<T> operation; |
There was a problem hiding this comment.
I think this gives the appearance of a setter. There won't be a static error for trying to set it... Is that a bug in the SDK?
There was a problem hiding this comment.
oh interesting...... cc @leafpetersen
There was a problem hiding this comment.
Going to leave this for now and follow up if we decide it needs to change.
There was a problem hiding this comment.
I do think this needs to change. #139
|
Collecting a list of potential breaking changes here dart-lang/core#328 |
natebosch
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests not migrated yet, but sending this out for review in the meantime.Tests migrated as well now