Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Remove references to the deprecated CastError. #118

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Remove references to the deprecated CastError. #118

merged 1 commit into from
Sep 21, 2020

Conversation

lrhn
Copy link
Contributor

@lrhn lrhn commented Jun 29, 2020

No description provided.

@lrhn lrhn requested a review from natebosch June 29, 2020 11:50
natebosch
natebosch reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump the min SDK in the pubspec and tested on Travis.

Perhaps we can hold this for after merging null safety?

@lrhn
Copy link
Contributor Author

lrhn commented Jul 13, 2020

Will hold off for now.

@mit-mit
Copy link

mit-mit commented Sep 17, 2020

@lrhn are we ready to more forward?

@lrhn
Copy link
Contributor Author

lrhn commented Sep 17, 2020

We should be, yes.

@lrhn
Copy link
Contributor Author

lrhn commented Sep 18, 2020

PTAL

@lrhn lrhn merged commit 3fedad2 into master Sep 21, 2020
@natebosch natebosch deleted the type-error branch September 21, 2020 16:48
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
@lrhn
Remove references to the deprecated CastError. (dart-archive/async#118)
9cc2c71
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lrhn @mit-mit @natebosch @googlebot