Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Fix error in CancelableOperation.then #127

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

whesse
Copy link
Contributor

@whesse whesse commented Jul 15, 2020

Replace a dynamic null check with a dynamic type cast, since the target type may be nullable.

Replace a dynamic null check with a dynamic type cast, since the target type may be nullable.
@whesse whesse requested a review from jakemac53 July 15, 2020 11:51
@whesse
Copy link
Contributor Author

whesse commented Jul 15, 2020

I don't know if you also want to change the package version in pubspec.yaml

@jakemac53
Copy link
Contributor

The pubspec version does not need to change - it hasn't yet been published (this is why we wait until landing in google3 before publishing!)

@jakemac53 jakemac53 merged commit 6b90f45 into master Jul 15, 2020
@jakemac53 jakemac53 deleted the fix_cancelable_operation branch July 15, 2020 13:56
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
Replace a dynamic null check with a dynamic type cast, since the target type may be nullable.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants