This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Resolve null safety migration TODOS #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from `StackTrace.fromString` to `AsyncError.defaultStackTrace`. - Remove a TODO about non-nullable `StackTrace`, by the time we merged null safety the type was already non-nullable and the TODO was stale. Style tweak - remove the argument names from a Function type that are redundant against their type names.
jakemac53
approved these changes
Aug 25, 2020
| // the sdk. | ||
| typedef HandleError<T> = void Function( | ||
| Object error, StackTrace stackTrace, EventSink<T> sink); | ||
| typedef HandleError<T> = void Function(Object error, StackTrace, EventSink<T>); |
There was a problem hiding this comment.
it feels weird to have the name specified for one of these and not the others, but 🤷♂️
There was a problem hiding this comment.
It's the only one where the type doesn't tell you what it is.
There was a problem hiding this comment.
Ya, I get that, but it still feels weird to me. I would be fine with removing it, as the name of the typedef itself I think makes it pretty clear, or I would also be fine with it as you have it.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
- Switch from `StackTrace.fromString` to `AsyncError.defaultStackTrace`. - Remove a TODO about non-nullable `StackTrace`, by the time we merged null safety the type was already non-nullable and the TODO was stale. Style tweak - remove the argument names from a Function type that are redundant against their type names.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackTrace.fromStringtoAsyncError.defaultStackTrace.StackTrace, by the time we mergednull safety the type was already non-nullable and the TODO was stale.
Style tweak - remove the argument names from a Function type that are
redundant against their type names.