This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Various clean-ups and null-safety improvements. #140
Merged
+46
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
commented
Oct 1, 2020
| @@ -42,7 +42,7 @@ class AsyncCache<T> { | |||
| /// The [duration] starts counting after the Future returned by [fetch] | |||
| /// completes, or after the Stream returned by [fetchStream] emits a done | |||
| /// event. | |||
| AsyncCache(this._duration); | |||
| AsyncCache(Duration duration) : _duration = duration; | |||
There was a problem hiding this comment.
Needed because [duration] in the dartdoc didn't have a target.
lrhn
commented
Oct 1, 2020
| @@ -30,6 +28,7 @@ class SingleSubscriptionTransformer<S, T> extends StreamTransformerBase<S, T> { | |||
| controller.addError(error, stackTrace); | |||
| } | |||
| }, onError: controller.addError, onDone: controller.close); | |||
| controller.onCancel = subscription.cancel; | |||
There was a problem hiding this comment.
You can avoid a lot of late by splitting creation and initialization when you have cyclic dependencies!
|
|
natebosch
approved these changes
Oct 16, 2020
|
@lrhn do you plan on revisiting this? Do you want me to pick it up and get travis passing? |
Make field final to silence lint.
|
Think I have made Travis happy now. |
natebosch
added a commit
that referenced
this pull request
Jan 29, 2021
This reverts commit 05b9553. Since this has not been published or rolled through to the SDK or Flutter we will hold it back to reduce risk.
natebosch
added a commit
that referenced
this pull request
Jan 29, 2021
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
…/async#140)" (dart-archive/async#152) This reverts commit 43e4a96. Since this has not been published or rolled through to the SDK or Flutter we will hold it back to reduce risk.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.