This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Fix a StreamGroup bug when a component stream's listen() throws #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would put the StreamGroup into an inconsistent state where it would believe itself to be active, but only some streams would have subscriptions. This was exacerbated by dart-lang/sdk#45815, which meant that even though _onListen threw an error a StreamSubscription was created and returned, so further callbacks could still be called. Now instead of going into an inconsistent state, the StreamGroup simply cancels itself.
lrhn
approved these changes
Apr 29, 2021
nex3
added a commit
that referenced
this pull request
May 3, 2021
I forgot to actually push these to the pull request.
nex3
added a commit
that referenced
this pull request
May 4, 2021
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
…-archive/async#173) This would put the StreamGroup into an inconsistent state where it would believe itself to be active, but only some streams would have subscriptions. This was exacerbated by dart-lang/sdkdart-lang/async#45815, which meant that even though _onListen threw an error a StreamSubscription was created and returned, so further callbacks could still be called. Now instead of going into an inconsistent state, the StreamGroup simply cancels itself.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
I forgot to actually push these to the pull request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would put the StreamGroup into an inconsistent state where it
would believe itself to be active, but only some streams would have
subscriptions. This was exacerbated by dart-lang/sdk#45815, which
meant that even though _onListen threw an error a StreamSubscription
was created and returned, so further callbacks could still be called.
Now instead of going into an inconsistent state, the StreamGroup
simply cancels itself.