This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Revert change of visible behavior in CancelableOperation.
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prior change made it so that a `.then` on a `CancelableOperation` would call the `onValue`/`onError` callback even if the returned operation was cancelled beteen the time of the `then` and the time the original operation completed. The result would not show up in the cancelled operation, but the callbacks would run. This change blocks calling the callbacks if the returned operation has been cancelled.
lrhn
force-pushed
the
fix-callbacks-after-cancel
branch
from
c3da3bb to
8f77efd
Compare
lrhn
force-pushed
the
fix-callbacks-after-cancel
branch
from
8f77efd to
88c0f72
Compare
natebosch
approved these changes
Mar 16, 2022
`fail` has a return type of `Never`.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
…hive/async#208) * Revert change of visible behavior in `CancelableOperation`. A prior change made it so that a `.then` on a `CancelableOperation` would call the `onValue`/`onError` callback even if the returned operation was cancelled beteen the time of the `then` and the time the original operation completed. The result would not show up in the cancelled operation, but the callbacks would run. This change blocks calling the callbacks if the returned operation has been cancelled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior change made it so that a
.thenon aCancelableOperationwould call the
onValue/onErrorcallback even if thereturned operation was cancelled beteen the time of the
thenand the time the original operation completed.
The result would not show up in the cancelled operation,
but the callbacks would run.
This change blocks calling the callbacks if the returned operation
has been cancelled.
Q.v. #204