This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Bug a bug in StreamQueueTransaction.reject(). #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would throw a StateError if StreamQueue.rest had been called on one of the transaction's child queues, because that queue didn't expect to be canceled later on.
lrhn
reviewed
Feb 2, 2017
| controller.add(4); | ||
| controller.add(5); | ||
| }); | ||
|
|
||
| test("child requests' cancel() may still be called explicitly", () async { | ||
| transaction.reject(); |
There was a problem hiding this comment.
Unrelated comment: It's probably too late, but could we consider renaming reject to cancel? It's just so much more common, and it was the first name I looked for when I tried using the class.
There was a problem hiding this comment.
I think it's probably too late. I'm not sure I like cancel anyway—in other contexts it usually refers to finalization and releasing of resources, whereas for a transaction it's much more part of the normal flow of usage.
|
LGTM |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
This would throw a StateError if StreamQueue.rest had been called on one of the transaction's child queues, because that queue didn't expect to be canceled later on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would throw a StateError if StreamQueue.rest had been called on
one of the transaction's child queues, because that queue didn't expect
to be canceled later on.