-
Notifications
You must be signed in to change notification settings - Fork 50
Async cache won't store exceptions #258
Async cache won't store exceptions #258
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Any update on this @akmalviya03 @lrhn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
@natebosch WDYT?
This one doesn't have the same issue with a I don't think I have any concerns about landing this one. They are interesting to consider together though - adding this capability might give stronger motivation for accepting #260 |
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
@natebosch @lrhn Any update on this ? |
Closing as the dart-lang/async repository is merged into the dart-lang/core monorepo. Please re-open this PR there! |
Earlier async cache was caching exceptions.
With new changes in
fetch
method ofAsyncCache
class will no longer store exception.By default
AsyncCache
will store exception, by setting_canCacheException
to false. It won't store exception.Please refer dart-lang/core#366 for video demo of both issue and solution along with minimal reproducible code.