Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Add deps for build_runner #50

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Add deps for build_runner #50

merged 2 commits into from
Feb 24, 2018

Conversation

natebosch
Copy link
Contributor

Towards dart-lang/core#309

Allows us to run pub run build_runner test -- -p chrome to test with
DDC. Exposes issues with the package and with tests so not enabling on
Travis for now.

Towards #48

Allows us to run `pub run build_runner test -- -p chrome` to test with
DDC. Exposes issues with the package and with tests so not enabling on
Travis for now.
pubspec.yaml Outdated
@@ -11,3 +11,6 @@ dev_dependencies:
fake_async: "^0.1.2"
stack_trace: "^1.0.0"
test: "^0.12.0"
build_runner: ^0.7.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a # note here about why these are included – without other documentation or usage, it's not clear

@natebosch natebosch merged commit 256386f into master Feb 24, 2018
@natebosch natebosch deleted the ddc-tests branch February 24, 2018 01:08
@nex3
Copy link
Contributor

nex3 commented Feb 24, 2018

I'm 👎 on this change. I'm close to having test support DDC natively, and I'd prefer to solve dart-lang/core#309 that way rather than using the build system.

mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
Towards dart-lang/async#48

Allows us to run `pub run build_runner test -- -p chrome` to test with
DDC. Exposes issues with the package and with tests so not enabling on
Travis for now.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants