Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Remove upper case constants #56

Merged
merged 5 commits into from
May 3, 2018

Conversation

lrhn
Copy link
Contributor

@lrhn lrhn commented Apr 11, 2018

No description provided.

Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry.

@lrhn
Copy link
Contributor Author

lrhn commented Apr 12, 2018

What should the changelog say? Just "Updated SDK version to ...", or should it say why?

@lrhn
Copy link
Contributor Author

lrhn commented May 2, 2018

PTAL

nex3 added a commit that referenced this pull request May 2, 2018
We don't want to release this until #56 lands.
@lrhn lrhn force-pushed the remove-upper-case-constants branch from e1d6c09 to 6824da6 Compare May 3, 2018 11:53
@lrhn lrhn merged commit 1be9432 into dart-archive:master May 3, 2018
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 14, 2024
Remove usage of upper-case constants.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants