This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Change signature of methods overriding Future.then #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature is:
Future<T>.then (<S>((T) → dynamic, {onError: Function}) → Future<S>)
Use `dynamic` rather than leave off the type to future proof against
--no-implicit-dynamic
cleanup: dartfmt
|
This will help with dart-archive/bazel#40 |
|
Please remove dartfmt changes—this package doesn't use the formatter. |
nex3
suggested changes
Oct 21, 2016
|
|
||
| Future/*<S>*/ then/*<S>*/(/*=S*/ onValue(T value), {Function onError}) => | ||
| _future.then(onValue, onError: onError); | ||
| Future/*<S>*/ then/*<S>*/(dynamic onValue(T value), {Function onError}) => |
There was a problem hiding this comment.
What SDK version did this change in? We should set the minimum SDK constraint to that version.
There was a problem hiding this comment.
Looks like this particular bit changed in 1.19
|
Can you publish this or should I? |
|
Sorry meant to ping you about that right after I merged and then I got distracted. If you grant me uploader permission I can publish and tag it, otherwise if you want to publish that works too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature is:
Future<T>.then (<S>((T) → dynamic, {onError: Function}) → Future<S>)Use
dynamicrather than leave off the type to future proof against--no-implicit-dynamiccleanup: dartfmt