This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Travis: test oldest support SDK #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Apr 3, 2019
jakemac53
suggested changes
Apr 3, 2019
@matanlurey set these all up to run DDC back when we didn't have strong mode everywhere else. Now that we're past those days, cleaning this up substantially. |
|
This also drops the stages and runs the tests without build_runner right? I would instead keep the stages and run the tests with DDC only (if we want to run web tests at all). We could also add build_vm_compilers for running vm tests faster. |
|
I was trying to make things a bit more simple by testing in the standard
way.
Most of our other packages don't go through this dance.
…On Wed, Apr 3, 2019 at 12:25 PM Jacob MacDonald ***@***.***> wrote:
This also drops the stages and runs the tests without build_runner right?
I would instead keep the stages and run the tests with DDC only (if we
want to run web tests at all).
We could also add build_vm_compilers for running vm tests faster.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCiu7kTYxyqOpSihyA-QUFbwrEzcjgks5vdQAvgaJpZM4cbD4X>
.
|
Standardization is good, but we should be focused on doing the best thing not whatever all our other repos are doing, and moving forward into the future. With the latest kernel stuff for everything, I get these times: time pub run build_runner test -- -p vm -p chrome (full build)note there is >5s of extra time here because pub isn't precompiling build_runner time pub run build_runner test -- -p vm -p chrome (incremental build)time pub run test -p vm -p chromeThe incremental builds are significantly faster - and I think on travis you would even see the initial build be faster because the user time is significantly less ( |
|
@jakemac53 PTAL |
|
Also delete the |
done! |
jakemac53
approved these changes
Apr 3, 2019
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
* Drop web tests * Drop unused files * Delete travis.sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.