This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Refactor UnionSet deduplicating iterable #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Set.add` returns a boolean so it is unnecessary to use both `Set.contains` and then `Set.add`. Once the `.where` call is shortened to a tearoff the deduplication can be inlined with `_iterable`.
|
@natebosch – how'd you find THIS?!?! |
|
Saw some usage, wasn't familiar with the class and I was curious how much it was accomplishing. Jumped in to look at the implementation and the contains then add pattern stood out to me. |
jakemac53
reviewed
Feb 3, 2020
| /// values. | ||
| Iterable<E> get _iterable { | ||
| var allElements = _sets.expand((set) => set); | ||
| return _disjoint ? allElements : allElements.where(<E>{}.add); |
There was a problem hiding this comment.
While we are in here we might as well also make this a nevermind this actually seems to make things a bit worse 🤷♂️HashSet
jakemac53
approved these changes
Feb 3, 2020
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
`Set.add` returns a boolean so it is unnecessary to use both `Set.contains` and then `Set.add`. Once the `.where` call is shortened to a tearoff the deduplication can be inlined with `_iterable`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set.addreturns a boolean so it is unnecessary to use bothSet.containsand thenSet.add. Once the.wherecall is shortenedto a tearoff the deduplication can be inlined with
_iterable.