Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Null safety migration #123

Merged
merged 8 commits into from
Mar 17, 2020
Merged

Null safety migration #123

merged 8 commits into from
Mar 17, 2020

Conversation

jakemac53
Copy link
Contributor

Sending this one out for a review even before creating the official branch just due to the size of it, and the relative complexity of things like the Equality classes.

Note that not all tests are passing right now, the wrapper_test.dart is broken but due to violations in the test itself, and the PriorityQueue and QueueList tests are broken due to what I believe is an sdk issue which I will file and link here once I confirm.

@natebosch natebosch self-assigned this Mar 16, 2020
lib/src/algorithms.dart Outdated Show resolved Hide resolved
@jakemac53 jakemac53 changed the base branch from master to null_safety March 16, 2020 19:17
@jakemac53
Copy link
Contributor Author

jakemac53 commented Mar 16, 2020

SDK issue is here dart-lang/sdk#41060 This is resolved

lib/src/canonicalized_map.dart Outdated Show resolved Hide resolved
lib/src/functions.dart Show resolved Hide resolved
lib/src/priority_queue.dart Outdated Show resolved Hide resolved
lib/src/priority_queue.dart Show resolved Hide resolved
lib/src/queue_list.dart Outdated Show resolved Hide resolved
lib/src/union_set_controller.dart Outdated Show resolved Hide resolved
lib/src/union_set_controller.dart Outdated Show resolved Hide resolved
lib/src/wrappers.dart Show resolved Hide resolved
test/algorithms_test.dart Outdated Show resolved Hide resolved
@natebosch natebosch removed their assignment Mar 16, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jakemac53 jakemac53 merged commit 56748ed into null_safety Mar 17, 2020
@jakemac53 jakemac53 deleted the null-safety-migration branch March 17, 2020 18:00
lrhn pushed a commit that referenced this pull request Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants